[PATCH] D98740: [OpenMP] Change OMPIRBuilder to append function attributes

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 14:56:50 PDT 2021


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, two nits.



================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:49
+  for (size_t ArgNo = 0; ArgNo < Fn.arg_size(); ++ArgNo)
+    ArgAttrs.emplace_back(Fn.getAttributes().getParamAttributes(ArgNo));
+
----------------
no `llvm::` above. call getAttributes only once. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98740/new/

https://reviews.llvm.org/D98740



More information about the llvm-commits mailing list