[PATCH] D98634: [LV] Move runtime pointer size check to LVP::plan().

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LGTM
It seems that all/most of the reviewers who are familiar with this aren't responsive..



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:45-52
 static cl::opt<unsigned> VectorizeSCEVCheckThreshold(
     "vectorize-scev-check-threshold", cl::init(16), cl::Hidden,
     cl::desc("The maximum number of SCEV checks allowed."));
 
 static cl::opt<unsigned> PragmaVectorizeSCEVCheckThreshold(
     "pragma-vectorize-scev-check-threshold", cl::init(128), cl::Hidden,
     cl::desc("The maximum number of SCEV checks allowed with a "
----------------
fhahn wrote:
> lebedev.ri wrote:
> > These should move, too.
> Agreed, but I think it only really makes sense to move those once we make better cost-based decisions for them as well. WDYT?
Can you at least add a FIXME here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98634/new/

https://reviews.llvm.org/D98634