[PATCH] D99204: [LoopRotate] Hoist invariant loads

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 14:02:30 PDT 2021


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopRotationUtils.cpp:279
+      EquivalentValue = FindAvailableLoadedValue(
+          LI, ScanBB, ScanFrom, MaxInstsToScan, AA, &IsLoad, &NumScannedInst);
+    } while (EquivalentValue && dyn_cast<LoadInst>(EquivalentValue));
----------------
Why does this use FindAvailableLoadedValue if it isn't looking for available values? Can't you just use a loop over `isNoModRef(AA->getModRefInfo(I, Loc))`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99204/new/

https://reviews.llvm.org/D99204



More information about the llvm-commits mailing list