[PATCH] D99040: [RISCV] Add scheduler classes for the Zba and Zbb extensions.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoB.td:246
 def CLZ  : RVBUnary<0b0110000, 0b00000, 0b001, RISCVOpcode<0b0010011>, "clz">,
-           Sched<[]>;
+           Sched<[WriteCLZ,ReadCLZ]>;
 def CTZ  : RVBUnary<0b0110000, 0b00001, 0b001, RISCVOpcode<0b0010011>, "ctz">,
----------------
Various missing spaces after commas in this file


================
Comment at: llvm/lib/Target/RISCV/RISCVSchedRocket.td:177
 
+let Unsupported = true in {
+def : WriteRes<WriteRotateImm, []>;
----------------
craig.topper wrote:
> evandro wrote:
> > Perhaps consider placing the resources for the B instructions when they are not supported in a separate file for convenient inclusion in targets which do not support it.
> I'm worried that starts becoming unmanageable. You would need a file per sub extension which will quickly pollute the directory.
> 
> Maybe we need a multiclass to instantiate instead?
That seems like a sensible solution to me; I was also thinking about this problem but hadn't yet got round to commenting


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99040/new/

https://reviews.llvm.org/D99040