[PATCH] D99215: [lld-macho][nfc] Test that -ObjC will import bitcode with category sections

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 13:46:53 PDT 2021


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added subscribers: steven_wu, hiraditya.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The functionality was originally added in D95265: [lld-macho] Force-loading should share code path with regular archive loads <https://reviews.llvm.org/D95265>, but the test in that
diff only checked if `-ObjC` would cause bitcode containing ObjC class
symbols to be loaded. It neglected to test for bitcode containing
categories but no class symbols.

This diff also changes the lto-archive.ll test to use `-why_load`
instead of inspecting the output binary's symbol table. This is
motivated by the stacked diff D99105: [lld-macho] LTO: Properly set VisibleToRegularObj <https://reviews.llvm.org/D99105>, which will hide irrelevant
bitcode symbols.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99215

Files:
  lld/test/MachO/lto-archive.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99215.332780.patch
Type: text/x-patch
Size: 4904 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210323/04bcd15e/attachment.bin>


More information about the llvm-commits mailing list