[PATCH] D96938: [RFC] [Coroutine] [Debug] Insert dbg.declare to entry.resume to print alloca in the coroutine frame under O2

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 13:07:16 PDT 2021


aprantl added a comment.

Added one more question inline.



================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:666
+    auto *Storage = DDI->getAddress();
+    if (isa<Argument>(Storage)) {
+      auto &Entry = NewF->getEntryBlock();
----------------
I don't understand this change. Is this covered by your test? Are we even emitting dbg.declares when optimizations are turned on?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96938/new/

https://reviews.llvm.org/D96938



More information about the llvm-commits mailing list