[PATCH] D99210: [lld-macho][nfc] minor clean up, follow up to D98559
Vy Nguyen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 23 12:55:25 PDT 2021
oontvoo created this revision.
Herald added a subscriber: mgrang.
Herald added a reviewer: int3.
Herald added a project: lld-macho.
Herald added a reviewer: lld-macho.
oontvoo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D99210
Files:
lld/MachO/DriverUtils.cpp
lld/test/MachO/dependency-info.s
Index: lld/test/MachO/dependency-info.s
===================================================================
--- lld/test/MachO/dependency-info.s
+++ lld/test/MachO/dependency-info.s
@@ -1,7 +1,4 @@
# REQUIRES: x86
-## FIXME: Paths on windows have both `\` and '/', as a result, they are in a different
-## order when sorted. Maybe create a separate test for that?
-# UNSUPPORTED: system-windows
#
# RUN: rm -rf %t
# RUN: split-file %s %t
Index: lld/MachO/DriverUtils.cpp
===================================================================
--- lld/MachO/DriverUtils.cpp
+++ lld/MachO/DriverUtils.cpp
@@ -284,8 +284,8 @@
inputNames.reserve(inputs.size());
for (InputFile *f : inputs)
inputNames.push_back(f->getName());
- llvm::sort(inputNames,
- [](const StringRef &a, const StringRef &b) { return a < b; });
+ llvm::sort(inputNames);
+
for (const StringRef &in : inputNames)
addDep(DepOpCode::Input, in);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99210.332766.patch
Type: text/x-patch
Size: 944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210323/41176181/attachment.bin>
More information about the llvm-commits
mailing list