[PATCH] D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed)

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 12:30:47 PDT 2021


int3 added inline comments.


================
Comment at: lld/MachO/DriverUtils.cpp:287-288
+    inputNames.push_back(f->getName());
+  llvm::sort(inputNames,
+             [](const StringRef &a, const StringRef &b) { return a < b; });
+  for (const StringRef &in : inputNames)
----------------
I think this does the same thing?


================
Comment at: lld/test/MachO/dependency-info.s:2-4
+## FIXME: Paths on windows have both `\` and '/', as a result, they are in a different
+## order when sorted. Maybe create a separate test for that?
+# UNSUPPORTED: system-windows
----------------
can this be removed now that we have `CHECK-DAG`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98559/new/

https://reviews.llvm.org/D98559



More information about the llvm-commits mailing list