[PATCH] D98081: [AMDGPU] Improve Codegen for build_vector

Julien Pagès via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 12:07:44 PDT 2021


jpages updated this revision to Diff 332745.
jpages added a comment.

It appears that this instruction is harder to select than expected on integers.

One suggested way in offline discussions was to use isCanonicalized on the inputs.
With these modifications the instruction will be matched if and only if the inputs have been flushed/quieted already (for example by some floating point operations before).

Let me know it that seems reasonable or if I'm missing something.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98081/new/

https://reviews.llvm.org/D98081

Files:
  llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AMDGPU/v_pack.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98081.332745.patch
Type: text/x-patch
Size: 6141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210323/3af6dd7e/attachment.bin>


More information about the llvm-commits mailing list