[PATCH] D99198: [flang] Fix output buffering bug

Tue Mar 23 11:05:02 PDT 2021

klausler added a comment.

In D99198#2645322 <https://reviews.llvm.org/D99198#2645322>, @Leporacanthicus wrote:

> I'm wondering if it's possible to construct a test-case for this "shuffle it around" situation, so that some newbie (like me ...) doesn't break it accidentally when making changes?

It gets exercised pretty thoroughly by the I/O tests in the FCVS Fortran '77 suite, especially by codes doing direct and sequential I/O, and the flang/unittests/Runtime/external-io.cpp test really shook it out on the read path (and still passes with this change now that it's used on the write path).  But it would be nice to be able to make the code work harder by e.g. using an artificially small buffer size.  I've done that in the past during development (but obviously not for console output, sorry) but I'm not sure how it could be made part of a unit testing framework.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99198/new/

https://reviews.llvm.org/D99198