[PATCH] D99118: [SROA] Speculate around PHIs: allow load to be in a unique-successor unique-predecessor block

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 10:34:47 PDT 2021


lebedev.ri updated this revision to Diff 332718.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

Fix typo.

In D99118#2644501 <https://reviews.llvm.org/D99118#2644501>, @spatel wrote:

> In D99118#2642802 <https://reviews.llvm.org/D99118#2642802>, @nikic wrote:
>
>> I'm not really opposed to this change, but I'm also not sure it's necessary. Maybe in this case simply deleting the test case is the right thing to do?
>
> Another option: salvage the intent and move the test to PhaseOrdering as a `-O1` test?

Sure, i can do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99118/new/

https://reviews.llvm.org/D99118

Files:
  llvm/lib/Transforms/Scalar/SROA.cpp
  llvm/test/Transforms/SROA/2009-02-20-InstCombine-SROA.ll
  llvm/test/Transforms/SROA/phi-with-duplicate-pred.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99118.332718.patch
Type: text/x-patch
Size: 16302 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210323/699a3c5e/attachment.bin>


More information about the llvm-commits mailing list