[PATCH] D99198: [flang] Fix output buffering bug

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 09:53:42 PDT 2021


klausler created this revision.
klausler added a reviewer: kiranchandramohan.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
klausler requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The I/O runtime library code was failing to retain data in a buffer
from the current output record when flushing the buffer; this is
fatally wrong when the corresponding file cannot be repositioned,
as in the case of standard output to the console.  So refine the
Flush() member function to retain a specified number of bytes,
rearrange the data as necessary (using existing code for read frame
management after moving it into a new member function), and add
a big comment to the head of the file to clarify the roles of the
various data members in the management of contiguous frames in
circular buffers.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99198

Files:
  flang/runtime/buffer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99198.332706.patch
Type: text/x-patch
Size: 5394 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210323/f5dd450a/attachment.bin>


More information about the llvm-commits mailing list