[PATCH] D98152: [InstCombine] Canonicalize SPF to min/max intrinsics

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/Transforms/PhaseOrdering/X86/vector-reductions-expanded.ll:153
+; CHECK-NEXT:    [[TMP6:%.*]] = tail call i32 @llvm.smin.i32(i32 [[TMP5]], i32 [[TMP4]])
+; CHECK-NEXT:    ret i32 [[TMP6]]
 ;
----------------
spatel wrote:
> nikic wrote:
> > No longer vectorized?
> This requires rework in SLP. It assumes that min/max patterns are only in cmp+sel form. I made it work for FP (maxnum/minnum) already, so I'll take a look.
SLP and test updated:
3c8473ba534d / 9d45daf4656e
...so this diff should be gone now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98152/new/

https://reviews.llvm.org/D98152