[PATCH] D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns.

[Amy Kwan via Phabricator via llvm-commits]

amyk marked 24 inline comments as done.
amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16799
+    FlagSet |= PPC::MOF_SubtargetP9;
+    if (Subtarget.isISA3_1())
+      FlagSet |= PPC::MOF_SubtargetP10;
----------------
nemanjai wrote:
> I think this should be checking for prefixed instructions. It is entirely possible to have
> `-mcpu=pwr9 -Xclang -target-feature -Xclang -prefix-instrs` (or `llc -mattr=-prefix-instrs`).
I actually added a flag for prefixed instructions in https://reviews.llvm.org/D96075. Is this approach still acceptable, or would you prefer it to be done here instead in the approach you mentioned?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93370/new/

https://reviews.llvm.org/D93370