[PATCH] D99088: [flang][cmake] Improve how CLANG_DIR is handled

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 07:22:11 PDT 2021


awarzynski added a comment.

In D99088#2644491 <https://reviews.llvm.org/D99088#2644491>, @stevanradakovic wrote:

> One quick question. Otherwise looks good.

That was a typo, cheers for pointing out!

I've updated this patch a bit more. I think that the semantics of `CLANG_DIR` (and `{LLVM|MLIR}_DIR`) are a bit too convoluted. I hope that this will help clarifying. If this makes sense, I'll update `MLIR_DIR` and `LLVM_DIR` vars in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99088/new/

https://reviews.llvm.org/D99088



More information about the llvm-commits mailing list