[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda marked 8 inline comments as done.
yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/Object/GOFF.h:405
+
+class ContinuationRecord : public Record {
+public:
----------------
yusra.syeda wrote:
> kpn wrote:
> > Why make ContinuationRecord appear to be a type of record like ESD, HDR, and END are types of record? I'd have a layer that deals with cards and presents to the layer above it all payload data from initial and continued records combined. Then the code handling the various types of record wouldn't have to know about continuation records.
> Thanks for the suggestion, I will work on updating how continuation records are handled. 
I added handling of continuations to the Record class so it is now common between all records, and removed the ContinuationRecord class. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437