[PATCH] D99186: [WebAssembly] Rename WasmLimits::Initial to ::Minimum. NFC.

[Andy Wingo via Phabricator via llvm-commits]

wingo created this revision.
Herald added subscribers: ecnelises, rupprecht, jfb, arphaman, sunfish, hiraditya, jgravelle-google, sbc100, dschuff.
Herald added a reviewer: jhenderson.
wingo requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay, aheejin.
Herald added a project: LLVM.

This patch renames the "Initial" member of WasmLimits to the name used
in the spec, "Minimum".

In the core WebAssembly specification, the Limits data type has one
required "min" member and one optional "max" member, indicating the
minimum required size of the corresponding table or memory, and the
maximum size, if any.

Although the WebAssembly spec does instantiate locally-defined tables
and memories with the initial size being equal to the minimum size, it
can't impose such a requirement for imports.  It doesn't make sense to
require an initial size for a memory import, for example.  The compiler
can only sensibly express the minimum and maximum sizes.

See
https://github.com/WebAssembly/js-types/blob/master/proposals/js-types/Overview.md#naming-of-size-limits
for a related discussion that agrees that the right name of "initial" is
"minimum" when querying the type of a table or memory from JavaScript.
(Of course it still makes sense for JS to speak in terms of an initial
size when it explicitly instantiates memories and tables.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99186

Files:
  lld/test/wasm/alias.s
  lld/test/wasm/bsymbolic.s
  lld/test/wasm/call-indirect.ll
  lld/test/wasm/data-layout.s
  lld/test/wasm/export-table-explicit.test
  lld/test/wasm/export-table.test
  lld/test/wasm/growable-table.test
  lld/test/wasm/import-memory.test
  lld/test/wasm/import-table.test
  lld/test/wasm/large-memory.test
  lld/test/wasm/local-symbols.ll
  lld/test/wasm/locals-duplicate.test
  lld/test/wasm/multi-table.s
  lld/test/wasm/pie.ll
  lld/test/wasm/relocatable.ll
  lld/test/wasm/responsefile.test
  lld/test/wasm/shared-memory-no-atomics.yaml
  lld/test/wasm/shared-memory.yaml
  lld/test/wasm/shared.ll
  lld/test/wasm/stack-pointer.ll
  lld/test/wasm/undefined-weak-call.s
  lld/test/wasm/weak-alias-overide.ll
  lld/test/wasm/weak-alias.ll
  lld/test/wasm/weak-symbols.s
  lld/test/wasm/weak-undefined.s
  lld/wasm/SyntheticSections.cpp
  lld/wasm/Writer.cpp
  lld/wasm/WriterUtils.cpp
  llvm/include/llvm/BinaryFormat/Wasm.h
  llvm/include/llvm/ObjectYAML/WasmYAML.h
  llvm/lib/Object/WasmObjectFile.cpp
  llvm/lib/ObjectYAML/WasmEmitter.cpp
  llvm/lib/ObjectYAML/WasmYAML.cpp
  llvm/test/CodeGen/WebAssembly/call-indirect.ll
  llvm/test/CodeGen/WebAssembly/function-pointer64.ll
  llvm/test/MC/WebAssembly/assembler-binary.ll
  llvm/test/MC/WebAssembly/call-indirect-relocs.s
  llvm/test/MC/WebAssembly/comdat.ll
  llvm/test/MC/WebAssembly/data-section.s
  llvm/test/MC/WebAssembly/global-ctor-dtor.ll
  llvm/test/MC/WebAssembly/reloc-pic.s
  llvm/test/MC/WebAssembly/tables.s
  llvm/test/MC/WebAssembly/type-index.s
  llvm/test/MC/WebAssembly/wasm64.s
  llvm/test/MC/WebAssembly/weak-alias.s
  llvm/test/Object/wasm-relocs-and-producers.yaml
  llvm/test/ObjectYAML/wasm/data_section.yaml
  llvm/test/ObjectYAML/wasm/elem_section.yaml
  llvm/test/ObjectYAML/wasm/import_memory_shared.yaml
  llvm/test/ObjectYAML/wasm/import_section.yaml
  llvm/test/ObjectYAML/wasm/memory_section.yaml
  llvm/test/ObjectYAML/wasm/multiple-tables.yaml
  llvm/test/ObjectYAML/wasm/table_section.yaml
  llvm/tools/llvm-readobj/WasmDumper.cpp
  llvm/tools/obj2yaml/wasm2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99186.332662.patch
Type: text/x-patch
Size: 44163 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210323/9a8c70bb/attachment-0001.bin>