[PATCH] D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer

[Victor Huang via Phabricator via llvm-commits]

NeHuang marked 3 inline comments as done.
NeHuang added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:314
+  case XCOFF::XMC_UL:
+    assert(XCOFF::XTY_SD != MCSec->getCSectType() &&
+           "Mapping invalid csect. CSECT with tbss storage class must not be "
----------------
DiggerLin wrote:
> NeHuang wrote:
> > DiggerLin wrote:
> > > should be 
> > > XCOFF::XTY_CM == MCSec->getCSectType()  ?
> > For the TLS external reference case, we are setting SMC to `XCOFF::XMC_UL` with the csect type of ER in the function `TargetLoweringObjectFileXCOFF::getSectionForExternalReference`
> the TLS  external symbol  not put in the .tbss .
Yes, you are right. Updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98946/new/

https://reviews.llvm.org/D98946