[PATCH] D98351: [InstCombine] shrinkFPConstantVector(): scalable vector support

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/AArch64/sve-splat.ll:1
+; RUN: opt -instcombine -mtriple=aarch64-linux-gnu -mattr=+sve -S -o - < %s 2>%t | FileCheck %s
+; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
----------------
nasherm wrote:
> lebedev.ri wrote:
> > Do you really need anything other than plain `-instcombine` here?
> No, in practice there's no need. I added the triple and attributes to be in-line with the rest of the  AArch64 tests. 
This shouldn't even be a target-specific test, it doesn't test anything aarch64-specific.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98351/new/

https://reviews.llvm.org/D98351