[PATCH] D99088: [flang][cmake] Make sure that CLANG_DIR is an absolute path

Stevan Radaković via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 05:17:44 PDT 2021


stevanradakovic added a comment.

One quick question. Otherwise looks good.



================
Comment at: flang/CMakeLists.txt:54
+    get_filename_component(CLANG_DIR_ABSOLUTE ${CLANG_DIR} REALPATH)
+    list(APPEND CMAKE_MODULE_PATH ${CLANG_DIR_ABSOLUTEDIR})
+
----------------
Why CLANG_DIR_ABSOLUTEDIR when the var above is declared as CLANG_DIR_ABSOLUTE? Am I missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99088/new/

https://reviews.llvm.org/D99088



More information about the llvm-commits mailing list