[PATCH] D99173: Intrinsic::getName: require a Module argument

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere created this revision.
jeroen.dobbelaere added reviewers: fhahn, nikic, efriedma.
Herald added a reviewer: deadalnix.
Herald added subscribers: dexonsmith, hiraditya.
jeroen.dobbelaere requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Ensure that we provide a `Module` when checking if a rename of an intrinsic is necessary.

The Module argument is mandatory when unnamed types or pointer types are provided.
It is allowed to be `nullptr` when no type arguments or only non-pointer/non-unnamed type arguments
are provided.

This fixes the issue that was detected by https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32288
(as mentioned by @fhahn), after committing D91250 <https://reviews.llvm.org/D91250>.

Note that the `LLVMIntrinsicCopyOverloadedname` also gets the extra `LLVMModuleRef` argument.

This is an alternative for D99066 <https://reviews.llvm.org/D99066>.


https://reviews.llvm.org/D99173

Files:
  llvm/include/llvm-c/Core.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/lib/CodeGen/MachineOperand.cpp
  llvm/lib/CodeGen/ReplaceWithVeclib.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
  llvm/lib/IR/AutoUpgrade.cpp
  llvm/lib/IR/Core.cpp
  llvm/lib/IR/Function.cpp
  llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
  llvm/test/Assembler/auto_upgrade_intrinsics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99173.332621.patch
Type: text/x-patch
Size: 16104 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210323/37bc4e91/attachment.bin>