[PATCH] D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 23 04:19:21 PDT 2021
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
Thanks for the fix. LGTM.
================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1469
+ if (PIdx < 1) {
llvm_unreachable("trying to unpredicate a non-predicated instruction");
+ return;
----------------
It doesn't need both the assert and the unreachable - you can remove the if.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99075/new/
https://reviews.llvm.org/D99075
More information about the llvm-commits
mailing list