[PATCH] D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

I wonder if it would might be better update Value::replaceUsesWithIf instead, which would reach more code. Though that shape of that change might need some discussion. For instance, would we pass in the MetadataAsValue-ValueAsMetadata-Value debug uses to the predicate, or alternatively, have a a separate predicate for debug uses? wdyt?

Unrelated to my question, here are some fun stats for this patch since I have them to hand. llvm-locstats summary for RelWithDebInfo clang-3.4 built with clang main (@ 9c16621 <https://reviews.llvm.org/rG9c16621c0d4fccfa77b279f3b016b785d75b3989>):

  =================================================
  -the number of debug variables processed: 2635805
  -PC ranges covered: 66%
  -------------------------------------------------
  -total availability: 63%
  =================================================

llvm-locstats summary for RelWithDebInfo clang-3.4 built with clang (@ 9c16621 <https://reviews.llvm.org/rG9c16621c0d4fccfa77b279f3b016b785d75b3989>) with this patch applied:

  =================================================
  -the number of debug variables processed: 2655643 (+19,838)
  -PC ranges covered: 66% (+1%)
  -------------------------------------------------
  -total availability: 64% (+1%)
  =================================================


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99169/new/

https://reviews.llvm.org/D99169