[PATCH] D98969: [RISCV] Further optimize BUILD_VECTORs with repeated elements

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 03:39:30 PDT 2021


frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1279
+        continue;
+      if (ValueCounts[V] == 1)
+        Vec = DAG.getNode(ISD::INSERT_VECTOR_ELT, DL, VT, Vec, V,
----------------
craig.topper wrote:
> Put this block in curly braces for consistency with the else?
Aye thanks, I prefer it consistent. I wasn't sure what the style guidelines are for that situation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98969/new/

https://reviews.llvm.org/D98969



More information about the llvm-commits mailing list