[PATCH] D99069: [ValueTracking] Handle increasing mul recurrence in isKnownNonZero()

[JinGu Kang via Phabricator via llvm-commits]

jaykang10 added a comment.

In D99069#2642605 <https://reviews.llvm.org/D99069#2642605>, @nikic wrote:

> This looks good to me, but I think needs a couple more tests:
>
> - Positive test for nuw instead of nsw.
> - Negative test for zero start value.
> - Negative test for negative multiply. (We can't really test zero multiply, as it will get folded away.)
> - Negative test for negative start value -- alternatively, you can slightly extend this patch and split the start value check between add and mul: Add requires strictly positive start, but for mul non-zero is sufficient, I believe.

Yep, let me add more tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99069/new/

https://reviews.llvm.org/D99069