[PATCH] D93788: [X86] Transform amx pointer.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

a few style comments



================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:102
+  for (Value *IncValue : PN->incoming_values()) {
+    if (dyn_cast<BitCastInst>(IncValue))
+      continue;
----------------
isa<>


================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:130
+    Use &U = *(UI++);
+    if (dyn_cast<BitCastInst>(U.getUser()))
+      continue;
----------------
isa<>


================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:348
+          auto *ST = dyn_cast<StoreInst>(I);
+          if (ST) {
+            // %addr = bitcast <256 x i32>* %tile to x86_amx*
----------------
'''
if (auto *ST = dyn_cast<StoreInst>(I))
'''


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93788/new/

https://reviews.llvm.org/D93788