[PATCH] D99073: [lit] Reliable progress indicator and ETA

Tue Mar 23 01:45:17 PDT 2021

jhenderson added a comment.

I've not looked at this area enough to give a full LGTM, but am happy if others are.

================
Comment at: llvm/utils/lit/lit/display.py:51
+
+        # NOTE: median would be more precise, but might be too slow.
+        average_test_time = (self.time_elapsed + self.predictable_time_remaining) / \
----------------
lebedev.ri wrote:
> jhenderson wrote:
> > Is it a major bit of reworking to confirm whether median is slower than mean? I guess if it's straightforward, you could relatively quickly compare the total time for a significant set of tests before and after to see if it really is slower.
> It certainly won't be faster for obvious reasons. The question is how much of an overhead it will induce.
> For small number of tests (N=1'000, maybe N=10'000) it should be fine,
> but for N=100'000 i suspect it will not be good.
> In the end, it will mainly only help on the first run, when we don't have previous times for many of the tests.
> 
> Unless you insist, i think that may or may not be a follow-up improvement?
Fair enough. Not something I've thought about too much, and you're right that it could be a future improvement if really needed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99073/new/

https://reviews.llvm.org/D99073