[PATCH] D99073: [lit] Reliable progress indicator and ETA

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 01:36:15 PDT 2021


jhenderson added inline comments.


================
Comment at: llvm/utils/lit/lit/display.py:51
+
+        # NOTE: median would be more precise, but might be too slow.
+        average_test_time = (self.time_elapsed + self.predictable_time_remaining) / \
----------------
Is it a major bit of reworking to confirm whether median is slower than mean? I guess if it's straightforward, you could relatively quickly compare the total time for a significant set of tests before and after to see if it really is slower.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99073/new/

https://reviews.llvm.org/D99073



More information about the llvm-commits mailing list