[PATCH] D98967: [Analysis]Add getPointersDiff function to improve compile time.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 00:37:27 PDT 2021


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Can `isConsecutiveAccess()` be reimplemented in terms of `getPointersDiff()` now?
LGTM, but someone else should take a look, too.
Nice, https://llvm-compile-time-tracker.com/compare.php?from=bde995c9c2a0f73c69f1ca60b94bec0bebf20537&to=de67ba4218b6a64361e0269624a6998acb493b51&stat=instructions



================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:1206
+  };
+  std::set<DistOrdPair, decltype(Compare)> Offsets(Compare);
+  Offsets.emplace(0, 0);
----------------
Why is this no longer `llvm::SmallSet<>`?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:945-946
+      if (LI1 && LI2) {
+        if (LI1->getParent() != LI2->getParent())
+          return VLOperands::ScoreFail;
+
----------------
This looks like a separate change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98967/new/

https://reviews.llvm.org/D98967



More information about the llvm-commits mailing list