[PATCH] D98903: [SanitizerCoverage] Make __start_/__stop_ symbols extern_weak
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 22 23:07:49 PDT 2021
MaskRay added a subscriber: rnk.
MaskRay added a comment.
Fixed by 3c81822ec5d2375d243ef2d43468807aa96383ec <https://reviews.llvm.org/rG3c81822ec5d2375d243ef2d43468807aa96383ec>. I used this comment:
+ // Windows defines the start/stop symbols in compiler-rt so no need for
+ // ExternalWeak.
(See lib/sanitizer_common/sanitizer_coverage_win_sections.cpp)
The comment could be improved if I knew why the test (https://lab.llvm.org/buildbot/#/builders/127/builds/8015) failed... @rnk
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98903/new/
https://reviews.llvm.org/D98903
More information about the llvm-commits
mailing list