[PATCH] D98957: [NFCI] [TransformUtils] cleanup `CloneFunctionInto`
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 22 20:44:09 PDT 2021
dexonsmith accepted this revision.
dexonsmith added a comment.
Thanks for cleaning this up!
Mostly LGTM, just please split this up into three separate commits (no need for new reviews; any order seems fine, as they seem fully independent):
- Move the early return and fixing the assertion message (capitalized, as @nikic mentioned).
- NFC refactorings.
- Unrelated whitespace changes (BTW, if you just got these incidentally, you can use git-clang-format in the future to just change the lines your commit is touching...).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98957/new/
https://reviews.llvm.org/D98957
More information about the llvm-commits
mailing list