[PATCH] D99139: [lld][ELF] --warn-backrefs: Fix symbol name demangling

[Yang Fan via Phabricator via llvm-commits]

nullptr.cpp created this revision.
nullptr.cpp added reviewers: ruiu, MaskRay, grimar.
Herald added subscribers: steven_wu, hiraditya, arichardson, emaste.
nullptr.cpp requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In the warning of `--warn-backrefs`, symbol names should be:

- demangled with `--demangle`
- mangled with `--no-demangle`


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99139

Files:
  lld/ELF/Symbols.cpp
  lld/test/ELF/lto/warn-backrefs-demangle.ll
  lld/test/ELF/lto/warn-backrefs-no-demangle.ll


Index: lld/test/ELF/lto/warn-backrefs-no-demangle.ll
===================================================================
--- /dev/null
+++ lld/test/ELF/lto/warn-backrefs-no-demangle.ll
@@ -0,0 +1,30 @@
+; REQUIRES: x86
+;; Test that the referenced filename is correct (not <internal> or lto.tmp).
+
+; RUN: split-file %s %t
+; RUN: llvm-as %t/a.ll -o %ta.o
+; RUN: llvm-as %t/b.ll -o %tb.o
+; RUN: ld.lld --no-demangle --warn-backrefs --start-lib %tb.o --end-lib %ta.o -o /dev/null 2>&1 | FileCheck %s
+
+; CHECK: warning: backward reference detected: _Z1fv in {{.*}}a.o refers to {{.*}}b.o
+
+;--- a.ll
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+declare void @_Z1fv()
+
+define void @_start() {
+entry:
+  call void () @_Z1fv()
+  ret void
+}
+
+;--- b.ll
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define void @_Z1fv() {
+entry:
+  ret void
+}
Index: lld/test/ELF/lto/warn-backrefs-demangle.ll
===================================================================
--- /dev/null
+++ lld/test/ELF/lto/warn-backrefs-demangle.ll
@@ -0,0 +1,30 @@
+; REQUIRES: x86
+;; Test that the referenced filename is correct (not <internal> or lto.tmp).
+
+; RUN: split-file %s %t
+; RUN: llvm-as %t/a.ll -o %ta.o
+; RUN: llvm-as %t/b.ll -o %tb.o
+; RUN: ld.lld --demangle --warn-backrefs --start-lib %tb.o --end-lib %ta.o -o /dev/null 2>&1 | FileCheck %s
+
+; CHECK: warning: backward reference detected: f() in {{.*}}a.o refers to {{.*}}b.o
+
+;--- a.ll
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+declare void @_Z1fv()
+
+define void @_start() {
+entry:
+  call void () @_Z1fv()
+  ret void
+}
+
+;--- b.ll
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define void @_Z1fv() {
+entry:
+  ret void
+}
Index: lld/ELF/Symbols.cpp
===================================================================
--- lld/ELF/Symbols.cpp
+++ lld/ELF/Symbols.cpp
@@ -385,7 +385,7 @@
         break;
       }
     if (!exclude)
-      warn("backward reference detected: " + sym.getName() + " in " +
+      warn("backward reference detected: " + toString(sym) + " in " +
            toString(it.second.first) + " refers to " + to);
   }
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99139.332510.patch
Type: text/x-patch
Size: 2491 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210323/7870bd53/attachment.bin>