[PATCH] D98899: [DAE] Adjust param/arg attributes when changing parameter to undef

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 22 18:39:46 PDT 2021


Carrot added a comment.

In D98899#2640159 <https://reviews.llvm.org/D98899#2640159>, @nikic wrote:

> This looks reasonable to me. Dropping nonnull is not strictly necessary (because it has no immediate UB), but doesn't hurt either.
>
> I was going to suggest using AttrBuilder to drop all attributes at once, but I'm not sure that works with dereferenceable attributes.

Thanks for the good suggestion. 
According to the implementation of AttrBuilder::remove, it can remove dereferenceable attribute from another AttrBuilder with any dereferenceable bytes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98899/new/

https://reviews.llvm.org/D98899



More information about the llvm-commits mailing list