[llvm] b37d0a4 - [deref] Split a test to show both global and pointwise semantics
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 22 18:35:00 PDT 2021
Author: Philip Reames
Date: 2021-03-22T18:34:40-07:00
New Revision: b37d0a40a292cd993d7dafb7116794788e93ba6c
URL: https://github.com/llvm/llvm-project/commit/b37d0a40a292cd993d7dafb7116794788e93ba6c
DIFF: https://github.com/llvm/llvm-project/commit/b37d0a40a292cd993d7dafb7116794788e93ba6c.diff
LOG: [deref] Split a test to show both global and pointwise semantics
While doing so, also split one monster test into individually named test functions.
Added:
Modified:
llvm/test/Analysis/ValueTracking/memory-dereferenceable.ll
Removed:
################################################################################
diff --git a/llvm/test/Analysis/ValueTracking/memory-dereferenceable.ll b/llvm/test/Analysis/ValueTracking/memory-dereferenceable.ll
index 95ba9f2a1ddf..af3a6e1c11d9 100644
--- a/llvm/test/Analysis/ValueTracking/memory-dereferenceable.ll
+++ b/llvm/test/Analysis/ValueTracking/memory-dereferenceable.ll
@@ -1,5 +1,8 @@
-; RUN: opt -print-memderefs -analyze -S < %s -enable-new-pm=0 | FileCheck %s
-; RUN: opt -passes=print-memderefs -S < %s -disable-output 2>&1 | FileCheck %s
+; RUN: opt -print-memderefs -analyze -S < %s -enable-new-pm=0 -use-dereferenceable-at-point-semantics=0 | FileCheck %s --check-prefixes=CHECK,GLOBAL
+; RUN: opt -passes=print-memderefs -S < %s -disable-output -use-dereferenceable-at-point-semantics=0 2>&1 | FileCheck %s --check-prefixes=CHECK,GLOBAL
+; RUN: opt -print-memderefs -analyze -S < %s -enable-new-pm=0 -use-dereferenceable-at-point-semantics=1 | FileCheck %s --check-prefixes=CHECK,POINT
+; RUN: opt -passes=print-memderefs -S < %s -disable-output -use-dereferenceable-at-point-semantics=1 2>&1 | FileCheck %s --check-prefixes=CHECK,POINT
+
; Uses the print-deref (+ analyze to print) pass to run
; isDereferenceablePointer() on many load instruction operands
@@ -20,42 +23,34 @@ declare i32* @foo()
@globalptr.align1 = external global i8, align 1
@globalptr.align16 = external global i8, align 16
+; Loads from sret arguments
+; CHECK-LABEL: 'test_sret'
+; GLOBAL: %sret_gep{{.*}}(aligned)
+; POINT-NOT: %sret_gep{{.*}}(aligned)
+; CHECK-NOT: %sret_gep_outside
+define void @test_sret(%struct.A* sret(%struct.A) %result) {
+ %sret_gep = getelementptr inbounds %struct.A, %struct.A* %result, i64 0, i32 1, i64 2
+ load i8, i8* %sret_gep
+
+ %sret_gep_outside = getelementptr %struct.A, %struct.A* %result, i64 0, i32 1, i64 7
+ load i8, i8* %sret_gep_outside
+ ret void
+}
+
; CHECK-LABEL: 'test'
-define void @test(%struct.A* sret(%struct.A) %result,
- i32 addrspace(1)* dereferenceable(8) %dparam,
+define void @test(i32 addrspace(1)* dereferenceable(8) %dparam,
i8 addrspace(1)* dereferenceable(32) align 1 %dparam.align1,
- i8 addrspace(1)* dereferenceable(32) align 16 %dparam.align16,
- i8* byval(i8) %i8_byval,
- %struct.A* byval(%struct.A) %A_byval)
+ i8 addrspace(1)* dereferenceable(32) align 16 %dparam.align16)
gc "statepoint-example" {
; CHECK: The following are dereferenceable:
entry:
-; CHECK: %globalptr{{.*}}(aligned)
- %globalptr = getelementptr inbounds [6 x i8], [6 x i8]* @globalstr, i32 0, i32 0
- %load1 = load i8, i8* %globalptr
-
-; CHECK: %alloca{{.*}}(aligned)
- %alloca = alloca i1
- %load2 = load i1, i1* %alloca
-
- ; Load from empty array alloca
-; CHECK-NOT: %empty_alloca
- %empty_alloca = alloca i8, i64 0
- %empty_load = load i8, i8* %empty_alloca
-
- ; Loads from sret arguments
-; CHECK: %sret_gep{{.*}}(aligned)
- %sret_gep = getelementptr inbounds %struct.A, %struct.A* %result, i64 0, i32 1, i64 2
- load i8, i8* %sret_gep
-; CHECK-NOT: %sret_gep_outside
- %sret_gep_outside = getelementptr %struct.A, %struct.A* %result, i64 0, i32 1, i64 7
- load i8, i8* %sret_gep_outside
-
-; CHECK: %dparam{{.*}}(unaligned)
+; GLOBAL: %dparam{{.*}}(unaligned)
+; POINT-NOT: %dparam{{.*}}(unaligned)
%load3 = load i32, i32 addrspace(1)* %dparam
-; CHECK: %relocate{{.*}}(unaligned)
+; GLOBAL: %relocate{{.*}}(unaligned)
+; POINT-NOT: %relocate{{.*}}(unaligned)
%tok = tail call token (i64, i32, i1 ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_i1f(i64 0, i32 0, i1 ()* @return_i1, i32 0, i32 0, i32 0, i32 0) ["gc-live" (i32 addrspace(1)* %dparam)]
%relocate = call i32 addrspace(1)* @llvm.experimental.gc.relocate.p1i32(token %tok, i32 0, i32 0)
%load4 = load i32, i32 addrspace(1)* %relocate
@@ -71,7 +66,8 @@ entry:
%load6 = load i32, i32* %nd_load
; Load from a dereferenceable load
-; CHECK: %d4_load{{.*}}(unaligned)
+; GLOBAL: %d4_load{{.*}}(unaligned)
+; POINT-NOT: %d4_load{{.*}}(unaligned)
%d4_load = load i32*, i32** @globali32ptr, !dereferenceable !0
%load7 = load i32, i32* %d4_load
@@ -86,57 +82,28 @@ entry:
%load9 = load i32, i32* %d_or_null_load
; Load from a non-null pointer with dereferenceable_or_null
-; CHECK: %d_or_null_non_null_load{{.*}}(unaligned)
+; GLOBAL: %d_or_null_non_null_load{{.*}}(unaligned)
+; POINT-NOT: %d_or_null_non_null_load{{.*}}(unaligned)
%d_or_null_non_null_load = load i32*, i32** @globali32ptr, !nonnull !2, !dereferenceable_or_null !0
%load10 = load i32, i32* %d_or_null_non_null_load
- ; It's OK to overrun static array size as long as we stay within underlying object size
-; CHECK: %within_allocation{{.*}}(aligned)
- %within_allocation = getelementptr inbounds %struct.A, %struct.A* @globalstruct, i64 0, i32 0, i64 10
- %load11 = load i8, i8* %within_allocation
-
- ; GEP is outside the underlying object size
-; CHECK-NOT: %outside_allocation
- %outside_allocation = getelementptr inbounds %struct.A, %struct.A* @globalstruct, i64 0, i32 1, i64 10
- %load12 = load i8, i8* %outside_allocation
-
- ; Loads from aligned globals
-; CHECK: @globalptr.align1{{.*}}(unaligned)
-; CHECK: @globalptr.align16{{.*}}(aligned)
- %load13 = load i8, i8* @globalptr.align1, align 16
- %load14 = load i8, i8* @globalptr.align16, align 16
-
; Loads from aligned arguments
-; CHECK: %dparam.align1{{.*}}(unaligned)
-; CHECK: %dparam.align16{{.*}}(aligned)
+; GLOBAL: %dparam.align1{{.*}}(unaligned)
+; POINT-NOT: %dparam.align1{{.*}}(unaligned)
+; POINT-NOT: %dparam.align16{{.*}}(aligned)
+; GLOBAL: %dparam.align16{{.*}}(aligned)
%load15 = load i8, i8 addrspace(1)* %dparam.align1, align 16
%load16 = load i8, i8 addrspace(1)* %dparam.align16, align 16
- ; Loads from byval arguments
-; CHECK: %i8_byval{{.*}}(aligned)
- %i8_byval_load = load i8, i8* %i8_byval
-
-; CHECK-NOT: %byval_cast
- %byval_cast = bitcast i8* %i8_byval to i32*
- %bad_byval_load = load i32, i32* %byval_cast
-
-; CHECK: %byval_gep{{.*}}(aligned)
- %byval_gep = getelementptr inbounds %struct.A, %struct.A* %A_byval, i64 0, i32 1, i64 2
- load i8, i8* %byval_gep
-
- ; Loads from aligned allocas
-; CHECK: %alloca.align1{{.*}}(unaligned)
-; CHECK: %alloca.align16{{.*}}(aligned)
- %alloca.align1 = alloca i1, align 1
- %alloca.align16 = alloca i1, align 16
- %load17 = load i1, i1* %alloca.align1, align 16
- %load18 = load i1, i1* %alloca.align16, align 16
-
; Loads from GEPs
-; CHECK: %gep.align1.offset1{{.*}}(unaligned)
-; CHECK: %gep.align16.offset1{{.*}}(unaligned)
-; CHECK: %gep.align1.offset16{{.*}}(unaligned)
-; CHECK: %gep.align16.offset16{{.*}}(aligned)
+; GLOBAL: %gep.align1.offset1{{.*}}(unaligned)
+; GLOBAL: %gep.align16.offset1{{.*}}(unaligned)
+; GLOBAL: %gep.align1.offset16{{.*}}(unaligned)
+; GLOBAL: %gep.align16.offset16{{.*}}(aligned)
+; POINT-NOT: %gep.align1.offset1{{.*}}(unaligned)
+; POINT-NOT: %gep.align16.offset1{{.*}}(unaligned)
+; POINT-NOT: %gep.align1.offset16{{.*}}(unaligned)
+; POINT-NOT: %gep.align16.offset16{{.*}}(aligned)
%gep.align1.offset1 = getelementptr inbounds i8, i8 addrspace(1)* %dparam.align1, i32 1
%gep.align16.offset1 = getelementptr inbounds i8, i8 addrspace(1)* %dparam.align16, i32 1
%gep.align1.offset16 = getelementptr inbounds i8, i8 addrspace(1)* %dparam.align1, i32 16
@@ -147,8 +114,10 @@ entry:
%load22 = load i8, i8 addrspace(1)* %gep.align16.offset16, align 16
; CHECK-NOT: %no_deref_return
-; CHECK: %deref_return{{.*}}(unaligned)
-; CHECK: %deref_and_aligned_return{{.*}}(aligned)
+; GLOBAL: %deref_return{{.*}}(unaligned)
+; GLOBAL: %deref_and_aligned_return{{.*}}(aligned)
+; POINT-NOT: %deref_return{{.*}}(unaligned)
+; POINT-NOT: %deref_and_aligned_return{{.*}}(aligned)
%no_deref_return = call i32* @foo()
%deref_return = call dereferenceable(32) i32* @foo()
%deref_and_aligned_return = call dereferenceable(32) align 16 i32* @foo()
@@ -157,24 +126,105 @@ entry:
%load25 = load i32, i32* %deref_and_aligned_return, align 16
; Load from a dereferenceable and aligned load
-; CHECK: %d4_unaligned_load{{.*}}(unaligned)
-; CHECK: %d4_aligned_load{{.*}}(aligned)
+; GLOBAL: %d4_unaligned_load{{.*}}(unaligned)
+; GLOBAL: %d4_aligned_load{{.*}}(aligned)
+; POINT-NOT: %d4_unaligned_load{{.*}}(unaligned)
+; POINT-NOT: %d4_aligned_load{{.*}}(aligned)
%d4_unaligned_load = load i32*, i32** @globali32ptr, !dereferenceable !0
%d4_aligned_load = load i32*, i32** @globali32ptr, !dereferenceable !0, !align !{i64 16}
%load26 = load i32, i32* %d4_unaligned_load, align 16
%load27 = load i32, i32* %d4_aligned_load, align 16
+ ret void
+}
- ; Alloca with no explicit alignment is aligned to preferred alignment of
- ; the type (specified by datalayout string).
+; Loads from aligned allocas
+; CHECK-LABEL: 'alloca_aligned'
+; CHECK: %alloca.align1{{.*}}(unaligned)
+; CHECK: %alloca.align16{{.*}}(aligned)
+define void @alloca_aligned() {
+ %alloca.align1 = alloca i1, align 1
+ %alloca.align16 = alloca i1, align 16
+ %load17 = load i1, i1* %alloca.align1, align 16
+ %load18 = load i1, i1* %alloca.align16, align 16
+ ret void
+}
+
+; CHECK-LABEL: 'alloca_basic'
+; CHECK: %alloca{{.*}}(aligned)
+define void @alloca_basic() {
+ %alloca = alloca i1
+ %load2 = load i1, i1* %alloca
+ ret void
+}
+
+; Load from empty array alloca
+; CHECK-LABEL: 'alloca_empty'
+; CHECK-NOT: %empty_alloca
+define void @alloca_empty() {
+ %empty_alloca = alloca i8, i64 0
+ %empty_load = load i8, i8* %empty_alloca
+ ret void
+}
+
+; Alloca with no explicit alignment is aligned to preferred alignment of
+; the type (specified by datalayout string).
+; CHECK-LABEL: 'alloca_perfalign'
; CHECK: %alloca.noalign{{.*}}(aligned)
- %alloca.noalign = alloca i32
- %load28 = load i32, i32* %alloca.noalign, align 8
+define void @alloca_perfalign() {
+ %alloca.noalign = alloca i32
+ %load28 = load i32, i32* %alloca.noalign, align 8
+ ret void
+}
- ret void
+; CHECK-LABEL: 'global'
+; CHECK: @globalptr.align1{{.*}}(unaligned)
+; CHECK: @globalptr.align16{{.*}}(aligned)
+; CHECK: %globalptr{{.*}}(aligned)
+define void @global() {
+ %load13 = load i8, i8* @globalptr.align1, align 16
+ %load14 = load i8, i8* @globalptr.align16, align 16
+
+ %globalptr = getelementptr inbounds [6 x i8], [6 x i8]* @globalstr, i32 0, i32 0
+ %load1 = load i8, i8* %globalptr
+ ret void
+}
+
+; It's OK to overrun static array size as long as we stay within underlying
+; object size
+; CHECK-LABEL: 'global_allocationsize'
+; CHECK: %within_allocation{{.*}}(aligned)
+; CHECK-NOT: %outside_allocation
+define void @global_allocationsize() {
+ %within_allocation = getelementptr inbounds %struct.A, %struct.A* @globalstruct, i64 0, i32 0, i64 10
+ %load11 = load i8, i8* %within_allocation
+
+ %outside_allocation = getelementptr inbounds %struct.A, %struct.A* @globalstruct, i64 0, i32 1, i64 10
+ %load12 = load i8, i8* %outside_allocation
+ ret void
+}
+
+; Loads from byval arguments
+; CHECK-LABEL: 'byval'
+; GLOBAL: %i8_byval{{.*}}(aligned)
+; POINT-NOT: %i8_byval{{.*}}(aligned)
+; CHECK-NOT: %byval_cast
+; GLOBAL: %byval_gep{{.*}}(aligned)
+; POINT-NOT: %byval_gep{{.*}}(aligned)
+define void @byval(i8* byval(i8) %i8_byval,
+ %struct.A* byval(%struct.A) %A_byval) {
+ %i8_byval_load = load i8, i8* %i8_byval
+
+ %byval_cast = bitcast i8* %i8_byval to i32*
+ %bad_byval_load = load i32, i32* %byval_cast
+
+ %byval_gep = getelementptr inbounds %struct.A, %struct.A* %A_byval, i64 0, i32 1, i64 2
+ load i8, i8* %byval_gep
+ ret void
}
; CHECK: The following are dereferenceable:
-; CHECK: %ptr = inttoptr i32 %val to i32*, !dereferenceable !0
+; GLOBAL: %ptr = inttoptr i32 %val to i32*, !dereferenceable !0
+; POINT-NOT: %ptr = inttoptr i32 %val to i32*, !dereferenceable !0
define i32 @f_0(i32 %val) {
%ptr = inttoptr i32 %val to i32*, !dereferenceable !0
%load29 = load i32, i32* %ptr, align 8
More information about the llvm-commits
mailing list