[PATCH] D99032: GlobalISel: Add FoldBinOpIntoSelect combine

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 22 18:14:35 PDT 2021


arsenm added a comment.

In D99032#2643254 <https://reviews.llvm.org/D99032#2643254>, @paquette wrote:

> Would it be hard to teach CSEMIRBuilder to handle the missing cases so that you can match top-down from the G_SELECT? It would be nice to avoid maintaining a list of constant-foldable opcodes if possible.

CSEMIRBuilder won't help here, and patterns apply bottom up. Really these are all constant foldable, we just don't handle a handful of them. I don't think it's that important and this could instead use the full list of binary opcodes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99032/new/

https://reviews.llvm.org/D99032



More information about the llvm-commits mailing list