[PATCH] D99110: [Coverage] Load records immediately

Choongwoo Han via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 22 16:15:22 PDT 2021


tunz marked 2 inline comments as done.
tunz added inline comments.


================
Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp:1064
       return std::move(Err);
 
     return std::move(Readers);
----------------
vsk wrote:
> Do the thin archive llvm-cov tests pass after deleting this? How?
It was my mistake. The ownership should be transferred to the caller. The test passed in my local machine just because the freed value was not overwritten.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99110/new/

https://reviews.llvm.org/D99110



More information about the llvm-commits mailing list