[PATCH] D98002: [RISCV] Add scheduling resources for V

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:232
 include "RISCVSchedule.td"
+include "RISCVScheduleV.td"
 include "RISCVRegisterInfo.td"
----------------
Maybe include this from RISCVSchedule.td the way RISCVInstrInfo.td includes RISCVInstrInfoV.td?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:1174
+                           "vfmerge.vfm", "$vd, $vs2, $rs1, v0">,
+                  Sched<[WriteVFMergeV, ReadVFMergeV, ReadVFMergeV]>;
 
----------------
frasercrmck wrote:
> Unsure here, but since this reads a scalar should it read something like `ReadVFMergeF`?
Do we need a Read for V0?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98002/new/

https://reviews.llvm.org/D98002