[PATCH] D98993: [COFF] Only consider associated EH sections during ICF

Mon Mar 22 15:07:11 PDT 2021

mstorsjo added a comment.

In D98993#2642758 <https://reviews.llvm.org/D98993#2642758>, @rnk wrote:

> In D98993#2639507 <https://reviews.llvm.org/D98993#2639507>, @mstorsjo wrote:
>
>> LGTM, this sounds sensible.
>>
>> Would this have fixed the issue in https://bugs.chromium.org/p/chromium/issues/detail?id=1144476 ?
>
> Yes, thanks, that's the issue I was referring to. :) I was away from my email when I wrote this, so I couldn't even dig it up to add to the description.

Ah, nice. :-)

I actually have a couple follow-up patches relating to when/where xdata/pdata are emitted - I think they should be safe wrt ICF but I didn't bother to risk anything back when I wrote them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98993/new/

https://reviews.llvm.org/D98993