[PATCH] D98898: [SimplifyCFG] use profile metadata to refine merging branch conditions

Mon Mar 22 13:19:01 PDT 2021

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.

In D98898#2642445 <https://reviews.llvm.org/D98898#2642445>, @spatel wrote:

> I think we should add the `unpredictable` override as a follow-up, so I have not added that yet, but if the consensus is to add it here, I can do that.

I think that's fine, but as before that we should probably document that in LangRef

================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2857
+  // predecessor branch is predictable, we may not want to merge them.
+  uint64_t TWeight, FWeight;
+  BranchProbability PBITrueProb, Likely;
----------------

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98898/new/

https://reviews.llvm.org/D98898