[PATCH] D99054: [lld][MachO] Make emitEndFunStab independent from .subsections_via_symbols

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 22 12:29:57 PDT 2021


int3 added a comment.

> P.S. I'm planning to improve the test coverage for stabs in a follow-up patch.

I think it would be nice to have it in this patch too. Code itself lgtm



================
Comment at: lld/MachO/Symbols.h:123
   uint32_t value;
+  uint32_t size;
 
----------------
should probably be uint64_t, as per my comment on the other diff


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99054/new/

https://reviews.llvm.org/D99054



More information about the llvm-commits mailing list