[PATCH] D99032: GlobalISel: Add FoldBinOpIntoSelect combine

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:904
+    const ConstantFP *FPImm = MI.getOperand(1).getFPImm();
+    return FPImm->isZero() && !FPImm->isNegative();
+  }
----------------
arsenm wrote:
> foad wrote:
> > Could use isNullValue here too?
> That is only on ConstantInt, not ConstantFP
No, it's on Constant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99032/new/

https://reviews.llvm.org/D99032