[PATCH] D98837: [lld][MachO] Refactor handling of subsections

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:468
 
-    uint64_t offset = sym.n_value - sec.addr;
+    uint32_t offset = sym.n_value - sec.addr;
 
----------------
int3 wrote:
> I think this should still be uint64_t?
oh, the offset within a subsection is uint32_t, and so is `Defined::value`... those are probably my mistakes, oops. Keep this uint64_t for now, and we can clean up the rest later?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98837/new/

https://reviews.llvm.org/D98837