[PATCH] D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed)

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/test/MachO/dependency-info.s:26
+# CHECK-NEXT: input-file: {{.*}}/main.o
+# CHECK-NEXT: input-file: {{.*}}/libSystem.tbd
+# CHECK-NEXT: bar.o
----------------
oontvoo wrote:
> thakis wrote:
> > I guess the problem is that these lines are sorted by name and libSystem is in the src tree and the rest are generated files, and the order of the names of build dir and src dir isn't predictable.
> Ah, good catch! Hmm, maybe I'll just grep -v `libSystem.tbd` from the output before we FileCheck?
> (Does anyone have a better solution?)
> 
> 
> 
> 
I guess you could just turn all the `CHECK-NEXT` lines into `CHECK-DAG`, and leave a comment saying that this is sorted but gives different orders due to the build/src dirs.

(As an aside, I'm not sure having these entries in sorted order is super important... I imagine anything that cares about monitoring dependencies just cares about the unordered set of input files)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98559/new/

https://reviews.llvm.org/D98559