[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

[Paulo Matos via Phabricator via llvm-commits]

pmatos added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrCall.td:86-92
+// Custom Funcref call node
+// This is lowered to table.set+call_indirect with reference types
+// But if we have in addition typed function references we can use call_ref
+def wasm_call_ref_t : SDTypeProfile<0, -1, [SDTCisVT<0, funcref>]>;
+def wasm_call_ref : SDNode<"WebAssemblyISD::CALL_REF", wasm_call_ref_t,
+                           [SDNPHasChain, SDNPOutGlue, SDNPOptInGlue,
+                            SDNPVariadic]>;
----------------
tlively wrote:
> Is this used anywhere?
Thanks for pointing this one out - I will remove this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95425/new/

https://reviews.llvm.org/D95425