[PATCH] D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic

Mon Mar 22 11:32:27 PDT 2021

Leporacanthicus added inline comments.

================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:109-116

+enum class OMPScheduleType {
+  Static = 34, /**< static unspecialized */
+  DynamicChunked = 35,
+  ModifierNonmonotonic =
+      (1 << 30), /**< Set if the nonmonotonic schedule modifier was present */
+  LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ ModifierNonmonotonic)
----------------
Meinersbur wrote:
> IMHO we should copy&paste the kmp_schedule enum here entirely, with a comment that it must be kept in sync.
> 
> Eventually `kmp.h` should include `OMPConstants.h` and use the declaration here instead of declaring its own.
I have added a comment to say that this needs to match kmp.h

I did look at copying the whole set of enum values, but I think that's better done at a later stage - I don't feel I understand exactly how these things are being used, and that would be key to how they get organized in a move. [Yes, could just copy the whole thing, but I'm not convinced that is the BEST choice - there appears to be a secondary hierarchy in there].

I will revisit this in a future patch, after I have spent some time understanding all the uses of these enum values.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97393/new/

https://reviews.llvm.org/D97393