[PATCH] D98176: Introduce a generic operator to apply complex operations to BitVector

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/ADT/BitVector.h:575
+    std::initializer_list<size_t> Sizes = {Args.size()...};
+    size_t CommonSize = *std::min_element(Sizes.begin(), Sizes.end());
+    if (Out.size() < CommonSize)
----------------
Shouldn't this be max_element rather than min_element?

(Or, can we change this class to make operations on differently-sized vectors illegal? This is hard to reason about.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98176/new/

https://reviews.llvm.org/D98176