[PATCH] D99080: Normalize usage of StrBoolAttr
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 22 10:54:33 PDT 2021
nikic added a comment.
Looks good conceptually. Only concern I have is that we used to emit some of these attributes with explicit `="false"` (I think -- correct me if I'm wrong), in which case existing bitcode would now be interpreted as if the attribute was enabled, not disabled. I think we need some AutoUpgrade handling to drop the attribute from existing bitcode in that case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99080/new/
https://reviews.llvm.org/D99080
More information about the llvm-commits
mailing list