[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

Apart from the one comment, LGTM.



================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1644-1650
+  Opts.EnableDIPreservationVerify = Args.hasArg(OPT_fverify_debuginfo_preserve);
+  // Ignore the option if the -fverify-debuginfo-preserve wasn't enabled.
+  if (Opts.EnableDIPreservationVerify &&
+      Args.hasArg(OPT_fverify_debuginfo_preserve_export)) {
+    Opts.DIBugsReportFilePath = std::string(
+        Args.getLastArgValue(OPT_fverify_debuginfo_preserve_export));
+  }
----------------
Any particular behaviour if the user specifies a file for `-fverify-debuginfo-preserve-export` but doesn't set `-fverify-debuginfo-preserve`? It seems like it would be worth emitting a warning in this case, though I'm not sure if that's an established precedent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82547/new/

https://reviews.llvm.org/D82547