[PATCH] D99087: [RISCV][WIP] Fix stack slot for argument types (Bug 49500)

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck created this revision.
frasercrmck added reviewers: luismarques, asb, rogfer01, mundaym.
Herald added subscribers: vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya.
frasercrmck requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

This is an complementary/alternative fix for D99068 <https://reviews.llvm.org/D99068>. It takes a slightly
different approach by explicitly summing up all of the required split
part type sizes and ensuring we allocate enough space for them. It also
takes the maximum alignment of each part.

I wasn't originally planning on publishing this as-is as it doesn't seem
quite right to me, but hopefully showing this alternative patch will
kick off some discussion.

There are certainly fewer changes to existing tests, compared with
D99068 <https://reviews.llvm.org/D99068>. But if @luismarques is right in that there is excessive stack
alignment then this patch needs further work.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99087

Files:
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-calling-conv.ll
  llvm/test/CodeGen/RISCV/stack-slot-size.ll
  llvm/test/CodeGen/RISCV/vector-abi.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99087.332326.patch
Type: text/x-patch
Size: 11198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210322/752cf76d/attachment.bin>