[PATCH] D98673: [llvm-reduce] Remove dso_local when possible

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceGlobalValues.cpp:1
+//===- ReduceGlobalValues.cpp - Specialized Delta Pass
+//----------------------===//
----------------
nit: this needs fixing?


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceGlobalValues.cpp:10
+//
+// This file implements a function which calls the Generic Delta pass in order
+// to reduce Global Values.
----------------
can we say more specifically what this reduces? It only reduces some attributes of globals.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceGlobalValues.h:1
+//===- ReduceGlobalValues.h - Specialized Delta Pass
+//---------------------------===//
----------------
nit: fix formatting?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98673/new/

https://reviews.llvm.org/D98673